Skip to content

Review sub devices v4 #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Review sub devices v4 #353

wants to merge 5 commits into from

Conversation

diptorupd
Copy link
Contributor

Cleaned up version of #343 and rebased on top of master

etotmeni and others added 5 commits April 1, 2021 20:01
1. create_sub_devices requires use of keyword argument parition.
   Usage is d.create_sub_devices(partition=4)
2. Plugged possible memory leak in create_sub_devices_by_counts
   which memory allocated for array would not be freed if sub-devices
   vector was returned NULL
3. Changed signature of create_sub_device_by_counts from accepting object
   of type list, to accepting any object, which is checked to be Sized
   (len(obj) is expected to work), and Iterable, i.s. iteration of
   elements works
4. Changes to accept all integral types, such as np.int32, not just python int.
5. Got rid of _raise_create_sub_devices_exception function, and replaced
   it with explicit raise CreateSubDevicesError(message)
@diptorupd diptorupd closed this Apr 2, 2021
@diptorupd diptorupd deleted the review-sub-devices_v4 branch April 2, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants